Skip to content

Set encoding to false to prevent image corruption #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Conversation

agibson-godaddy
Copy link
Contributor

@agibson-godaddy agibson-godaddy commented May 14, 2025

Issue: https://godaddy-corp.atlassian.net/browse/MWC-18161

Summary

This disables encoding, because having it enabled nukes non-text files, such as images and fonts.

Reference: gulpjs/gulp#2790

QA

@agibson-godaddy agibson-godaddy self-assigned this May 14, 2025
@ajaynes-godaddy ajaynes-godaddy marked this pull request as ready for review May 15, 2025 02:34
Copy link
Contributor

@ajaynes-godaddy ajaynes-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA in the PDF Product Vouchers PR checks out, LGTM!

@ajaynes-godaddy ajaynes-godaddy merged commit 32577ed into master May 15, 2025
@ajaynes-godaddy ajaynes-godaddy deleted the mwc-18161 branch May 15, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants