Skip to content

Fix encoding of not empty interface type #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Fix encoding of not empty interface type #284

merged 3 commits into from
Aug 30, 2021

Conversation

goccy
Copy link
Owner

@goccy goccy commented Aug 30, 2021

Since empty interface type and not empty interface type are different layout of type, we have to consider about it .

fix #281

@codecov-commenter
Copy link

Codecov Report

Merging #284 (97c3cf6) into master (a52bc68) will decrease coverage by 0.03%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   81.33%   81.30%   -0.04%     
==========================================
  Files          47       47              
  Lines       15530    15558      +28     
==========================================
+ Hits        12632    12650      +18     
- Misses       2338     2343       +5     
- Partials      560      565       +5     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marshal of interface leads memory corruption; "runtime: name offset out of range"
2 participants