Tests with multiple zf versions #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Required to initialize application | ||
| 'Zend\Router', | ||
| ], | ||
| if (class_exists('Zend\Router\Module')) { |
There was a problem hiding this comment.
I think this is fine as we are running inside our tests scope there Zend\Router\Module should always be defined.
So no need to check, or am I missing something?
There was a problem hiding this comment.
When you install zend mvc 2.x there is no explicit zend router module. With zend mvc 3.x there is an explicit zend router module which must be added to your list of modules.
This makes it quite difficult to support both versions with the same tests.
There was a problem hiding this comment.
Didn't check that one.. fine with me then :)
| @@ -10,7 +10,12 @@ | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^5.0 | ^6.0", | |||
| "zendframework/zend-mvc": "^2.0 | ^3.0" | |||
| "zendframework/zend-mvc": "^2.0 | ^3.0", | |||
| "zendframework/zend-view": "^2.0", | |||
There was a problem hiding this comment.
I added zend-mvc a week back. So its fine if there are more of them to execute tests properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs 3 travis builds with zend version 2 for servicemanager and mvc composer package.
One ugly part is, that it needs zend-view, zend-serializer, zend-log, zend-console and zend-i18n as requirement to initialize the application. We could either add this via travis.yml if we want to keep our composer.json clean. But in this case you can not execute the tests locally for zend version 2.
Any suggestions?
Another thought is to provide an own ServiceListener instance just for testing purposes which does not add all plugin managers.