Namespace change #11
Namespace change #11
Conversation
composer.json
Outdated
| @@ -6,7 +6,8 @@ | |||
| "license": "MIT", | |||
| "require": { | |||
| "goaop/framework": "^1.0|^2.0", | |||
| "zendframework/zend-modulemanager": "^2.0 | ^3.0" | |||
| "zendframework/zend-modulemanager": "^2.0 | ^3.0", | |||
| "symfony/console": "^3.0 || ^4.0" | |||
There was a problem hiding this comment.
What about the idea to put this just in the suggests section because it is not needed to use this module. It is just needed if you want to run the warm up command?
There was a problem hiding this comment.
Good point. Will change that and revoke the change in the binary to check if it is installed
|
Good work. It works with ZF3. We could adjust the tests to let them run with ZF2 and ZF3. I could do this when this PR is merged. And Version 2.0 sounds good. |
|
@reinfi could u check the warmup script as well then? If that works we could maybe change the naming too and remove zf2 from it |
Change namespace according to new specification. \Go\Zend\Framework
This will remove zf2 specific namings. These would mitmatch zend framework if you want to use this with ZF3. This will also add another functional test for goaop-warmup. Also add requirement for symfony/console since this is needed for warmup.
This is needed to actually run the functional warmup test
There was a problem hiding this comment.
For me it is fine, I think @lisachenko should have a look at it if he is fine with the new namespace. And then we are good to go for version 2.0 :-)
|
Yep. Maybe we should then split up master as |
|
Hi, for me this PR is ok! Just bump master to the next major version to keep BC promise and push current master branch as 1.x |
|
PS. Regarding cache warming process: there is the |
|
Good point tho. I'll create an enhancement ticket for us to rework the warmup then |
|
Ticket Created: #13 |
Changelog
Version suggestion: 2.0
Question:
I don't quite know if it works with ZF3 as a module. Do we need the support here or should we simply point to the new
zend-expressive-middlewarefor goaop? Otherwise I would add a comment in theREADME.mdto point that one out and remove the requirement incomposer.json