Fix handling of result types used in bodies #3559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only Collection result types need to be added to the generated roots. Adding other result types to it causes their DSL to run twice and therefore their views to get defined twice which causes the generation to fail.
The `buildHTTPResponseBody` and `buildHTTPRequestBody` functions already removed the `struct:pkg:path` meta when creating new types. They also need to remove the meta when renaming existing types as the renamed types live under the standard `gen` directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only Collection result types need to be added to the generated roots. Adding other result types to it causes their DSL to run twice and therefore their views to get defined twice which causes the generation to fail.