Skip to content

fix(#34076):replace assgniee translation key #34077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2025
Merged

fix(#34076):replace assgniee translation key #34077

merged 4 commits into from
Mar 31, 2025

Conversation

SimonPistache
Copy link
Contributor

@SimonPistache SimonPistache commented Mar 30, 2025 •
edited
Loading

Fix the typo on the filter_assginee_no_assigne key used in translations.

The typo itself doesn't produce a bug (as it's there both on the code and on the locales)

Side Note: Github UI is not the best to bulk change this :/ Squashing commits on the PR should be adequate.

Closes #34076 .

@GiteaBot
Copy link
Collaborator

@SimonPistache I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2025
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Mar 30, 2025
techknowlogick
techknowlogick approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Our bot will probably warn that files other than English are changed as they would be overwritten by the crowdin sync, but it’s probably not worth backing out the changes to the other files.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2025
lunny
lunny requested changes Mar 30, 2025
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning is right. You cannot change non-English translation directly. The changes will not be upload to crwodin, so that the files between gitea and crowdin will become inconsistent.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 30, 2025
@SimonPistache SimonPistache force-pushed the 34076-fix-assgniee-translation-key branch from 7d79fd0 to 5d7f89a Compare March 30, 2025 18:59
@SimonPistache SimonPistache force-pushed the 34076-fix-assgniee-translation-key branch from 5d7f89a to 5fa92af Compare March 30, 2025 19:03
@SimonPistache
Copy link
Contributor Author

SimonPistache commented Mar 30, 2025 •
edited
Loading

@lunny Understood, I updated the PR with only the changes on the code files, let alone the locales. I'm not versed on how Crowdin will piece things together, maybe its smart enough to get that the key has been renamed.

@techknowlogick
Copy link
Member

@lunny i think it's fine, and not worth spending the time to back them out. Their crowdin sync will handle that.

@lunny
Copy link
Member

lunny commented Mar 30, 2025

@lunny i think it's fine, and not worth spending the time to back them out. Their crowdin sync will handle that.

Wouldn't the next sync will overwrite the changes for non-English transactions files? I don't understand how the sync handle it?

@techknowlogick
Copy link
Member

@lunny yes it will, but I think it is ok for a robot to handle this case. Either way, it has been updated now, so I think you can update your review status.

@lunny
Copy link
Member

lunny commented Mar 30, 2025

@lunny Understood, I updated the PR with only the changes on the code files, let alone the locales. I'm not versed on how Crowdin will piece things together, maybe its smart enough to get that the key has been renamed.

English translation file should be changed. Only non English files cannot be updated.

@techknowlogick techknowlogick requested a review from lunny March 31, 2025 05:40
@lunny lunny force-pushed the 34076-fix-assgniee-translation-key branch from 7d631fb to 38333d3 Compare March 31, 2025 05:45
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 31, 2025
@lunny lunny added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 31, 2025
@SimonPistache
Copy link
Contributor Author

@lunny Understood, I updated the PR with only the changes on the code files, let alone the locales. I'm not versed on how Crowdin will piece things together, maybe its smart enough to get that the key has been renamed.

English translation file should be changed. Only non English files cannot be updated.

Oh I see you handled the change on the English file then, thank you!

@lunny lunny enabled auto-merge (squash) March 31, 2025 18:52
@lunny lunny merged commit 342432e into go-gitea:main Mar 31, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 31, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 1, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c480a69 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  fix users being able bypass limits with repo transfers (go-gitea#34031)
  Improve pull request list api (go-gitea#34052)
  fix(go-gitea#34076):replace assgniee translation key (go-gitea#34077)
  [Fix] Resolve the problem of commit_statuses not being loaded at the top - right when switching files from the file tree (go-gitea#34079)
  Enable testifylint rules (go-gitea#34075)
  Fix markup content overflow (go-gitea#34072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Key filter_assginee_no_assignee contain a typo
4 participants
@SimonPistache @GiteaBot @techknowlogick @lunny