-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add workflow_run api + webhook #33964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow_run api + webhook #33964
Conversation
Ready for review? |
My time to respond or make changes is limited in the next seven days, due to exams. Other than that, yes I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hurry, overall looks good. Thank you very much.
(Maybe will take a look again later)
…stopherHX/33964-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another round review. I think it looks good to me.
Is there anything else to change? If no, let's merge ~~ 🙏
Nothing that I am aware of, I agree with merging this now. Then I can polish the keda scaler side of things soon and move that one out of a draft. |
Implements
/actions/runs
for global + user + org (Gitea only)/actions/jobs
for global + user + org + repository (Gitea only)Fixes
runs/<run>
part to align with apiRefactoring
TODO
Closes #23670
Closes #23796
Closes #24898
Replaces #28047 and is much more complete