Skip to content

Use provided database Engine #17595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Use provided database Engine #17595

merged 2 commits into from
Nov 9, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 9, 2021

  • Don't get the engine from db.DefaultContext, instead use the
    provided one which is passed as paramater e.

- Don't get the engine from `db.DefaultContext`, instead use the
provided one which is passed as paramater `e`.
@Gusted Gusted added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/bug labels Nov 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17595 (1f2d878) into main (021df29) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17595      +/-   ##
==========================================
- Coverage   45.52%   45.49%   -0.03%     
==========================================
  Files         793      793              
  Lines       88854    88854              
==========================================
- Hits        40447    40425      -22     
- Misses      41896    41913      +17     
- Partials     6511     6516       +5     
Impacted Files Coverage Δ
models/user.go 55.55% <0.00%> (ø)
models/org.go 76.90% <100.00%> (ø)
modules/queue/workerpool.go 48.09% <0.00%> (-3.06%) ⬇️
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/notification.go 65.28% <0.00%> (-0.88%) ⬇️
models/repo_list.go 78.43% <0.00%> (-0.79%) ⬇️
models/issue_comment.go 51.31% <0.00%> (-0.30%) ⬇️
modules/queue/queue_channel.go 96.66% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021df29...1f2d878. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2021
@zeripath
Copy link
Contributor

zeripath commented Nov 9, 2021

make lgtm work

@zeripath zeripath merged commit 3a693bd into go-gitea:main Nov 9, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 9, 2021
@Gusted Gusted deleted the provided-engine branch November 24, 2021 08:26
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
- Don't get the engine from `db.DefaultContext`, instead use the
provided one which is passed as paramater `e`.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants