Attribute checker for commit xxxx exits with error: failed to run attr-check #34022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

TinyZzh opened this issue Mar 26, 2025 · 4 comments · Fixed by #34035

Labels

TinyZzh commented Mar 26, 2025 •

edited

Loading

Description

When I use Git to commit code to Gitea Repo, error logs related to attr-check are generated. However, I didn't observe any obvious exceptions in practice - the code was successfully committed. I'm unsure about the specific purpose of this attr-check. Could you please clarify:

What functionality does attr-check serve?
What impact might it have on operations?

Gitea Version

1.23.6

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

gogit

Operating System

Windows 10

How are you running Gitea?

Double-click gitea.exe.

Database

SQLite

TinyZzh added the type/bug label

Contributor

wxiaoguang commented Mar 26, 2025

It is a windows only problem, need some people who is using Windows to help to debug.

Duplicate:

Windows only: Unable to open checker for <commit id>. Error: failed to run attr-check. Error: exit status 1 #33550

Contributor

eeyrjmr commented Mar 26, 2025

I am seeing this as well, only recently and it might coincide with starting to use LFS (gitea keeps wanting to delete LFS data :( ).

Presently I can't associate these commit log issues with a real check to see if there is something to be mindful of.

Contributor

eeyrjmr commented Mar 26, 2025 •

edited

Loading

TRACE log has shown my five occurances of this is on one specific repository AND it is one where I am also seeing LFS issues where gitea thinks the LFS metadata is ophaned but it is valid lfs data.. funny enough the commit hash doesn't actually exist so something has gone odd...

Contributor

eeyrjmr commented Mar 26, 2025 •

edited

Loading

@TinyZzh are you using LFS as I have seen an issue with LFS (and windows) and it might be related as right now gitea things LFS data is orphaned and if I run doctor --fix it will delete valid LFS data

--edit--
Added a test pdf, associated with LFS... it was added fine, the LFS repo settings have it ok BUT gitea doctor would still want to delete the LFS as it is saying there is orphaned LFS files. I think this is associated with LFS and windows AND a new [E] Attribute checker appeared on this test repo right after a pdf file was pushed

charles7668 mentioned this issue

Fix the issue with error message logging for the check-attr command on Windows OS. #34035

Merged

wxiaoguang closed this as completed in #34035

wxiaoguang closed this as completed in

a759496

GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue


          Fix the issue with error message logging for the check-attr command…

155b74f

… on Windows OS. (go-gitea#34035)

Close go-gitea#34022 , go-gitea#33550 

This error message always appears when using the `check-attr` command,
even though it works correctly.
The issue occurs when the stdin writer is closed, so I added a special
case to handle and check the error message when the exit code is 1.

GiteaBot mentioned this issue

Fix the issue with error message logging for the check-attr command on Windows OS. (#34035) #34036

Merged

wxiaoguang pushed a commit that referenced this issue


          Fix the issue with error message logging for the check-attr command…

e46f9ff

… on Windows OS. (#34035) (#34036)

Backport #34035 by charles7668

Close #34022 , #33550 

This error message always appears when using the `check-attr` command,
even though it works correctly.
The issue occurs when the stdin writer is closed, so I added a special
case to handle and check the error message when the exit code is 1.

Co-authored-by: charles <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment