`scan: bufio.Scanner: token too long` when clicking actions sections

[silverwind]

Description

1. Open https://gitea.com/gitea/gitea-docusaurus/actions/runs/133/jobs/0
2. Click any section in the run
3. Nothing happens, stays stuck loading forever and logs an error in the console

Error should be made visible in UI, either inline at the loader or with a toast.

Gitea Version

1.20.0+dev-999-g8d7893e81

[wxiaoguang]

The ReadLog code doesn't handle a line which is longer than 65k bytes gracefully.

Ideally, the "token too long" error should be ignored and continue reading the logs.

[wolfogre]

The ReadLog code doesn't handle a line which is longer than 65k bytes gracefully.

No, it doesn't need to. The line will be truncated if it is too long before writing.

gitea/modules/actions/log.go

Lines 144 to 149 in 4011821

	func FormatLog(timestamp time.Time, content string) string {
	// Content shouldn't contain new line, it will break log indexes, other control chars are safe.
	content = strings.ReplaceAll(content, "\n", `\n`)
	if len(content) > MaxLineSize {
	content = content[:MaxLineSize]
	}

I think the real reason is that the log file is broken. It may be related to the malfunction of NFS on gitea.com a few days ago.

I logged on to the machine and downloaded the original log files:

---

And all is well after re-run.

[wolfogre]

I agree that errors should be visible in the UI. But I have no idea how to do that, so I will remove self-assignee.

[wxiaoguang]

How many "nil" chars there? Could there be a bug in DBFS code?

[wolfogre]

How many "nil" chars there? Could there be a bug in DBFS code?

The number of "nil" chars doesn't really matter. Since the total file size matches the file size recorded in the DB, and the "nil" chars end at the beginning of a line, it couldn't be that the DBFS lost some blocks.

It seems like it opened a non-existent file in DBFS , seek and write, but I have no idea how it could have happened. I will continue to track this bug to see if it happens again.

[wolfogre]

I confirmed that it is a bug and figured out the way to reproduce it. It's not related to DBFS or FS malfunction, but the logic of writing action logs.

I'll fix it.