Issue comment URLs parsed / emitted incorrectly

[noerw]

Gitea Version

a115309 (current 1.16), but I observed this since early in the 1.16 dev cycle

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://try.gitea.io/noerw/hochwasser/issues/5

Description

Issue comment references don't get parsed correctly, when it isn't the last thing on the line.
Looks like the HTML emitted is wrong, the word following the link is missing. The href is empty.
See try.gitea.io link above.

Screenshots

No response

[wxiaoguang]

Somehow related to #17398 , maybe the code can be improved more.

It is a Markdown rendering problem.

[wxiaoguang]

The problem is caused by the wrong HTML generated.

For example:

http://127.0.0.1:3000/root/test/issues/1#comment test

The genrated HTML is

<p><a href="http://127.0.0.1:3000/root/test/issues/1#comment test" class="ref-issue">#1</a></p>

Then SanitizeReader removes the invalid href.

[wxiaoguang]

Fixed in #17404

[noerw]

just noted that 1.15.5 is affected too

[wxiaoguang]

Yep, this is a very old bug, we can make a backport then