Slowly find where OSX/clang test fails. #262
Conversation
This is the baseline build of code for win_plots, where invalid windows plots were fixed and the keyboard focus was correctly restored for Linux. The Travis builds xxx.5, and xxx.10 failed via test_bug_2974380 this is for clang compiled on OSX systems. This first commit only submits the repaired devicewin.cpp, .hpp files (which are not used in OSX) If this passes the next step will be to activate the UnsetFocus() call in WShow.
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 41.49% 41.49% -0.01%
==========================================
Files 287 287
Lines 90961 90963 +2
==========================================
Hits 37744 37744
- Misses 53217 53219 +2
Continue to review full report at Codecov.
|
|
So, it is passing when UnsetFocus was re-inserted. Now however we have another significant insertion, |
|
And now the errors have returned once there is a wxWidget initialization call that actually |
Line 194 of src/graphicsdevice.cpp should be GDLWidget::Init(); but that call cannot be made and OSX/clang build will fail in the Travis CI tests. Otherwise, to summarize: UnsetFocus() is called thereby restoring correct window/keyboard focus operation under X, WIN devices. No good UnsetFocus() has been found for WX. NO_WIDGET_DRAW option will prevent accidental widget_draw widgets when you want none. GDLWidget::Init() and GDLWidget::UnInit() are each called from GraphicsDevice:: Greg Jung (aka maynardGK) [email protected]
|
@maynardGK should we add a "WIP" prefix to name of this PR? |
|
This is work finished, but it is very ugly stuff! basically I found out that OSX/Clang test will fail if we initialize widgets. I located the init() and uninit() routines to more functionally-appropriate locations and made widgets.cpp survive upon getting errors on a draw widget. For my own use I would tend to use only text aspect of widgets but want the best plot possible; in other applications the integrated Wx |
|
Actually omitting the GDLWidget::Init() does crush the widget capability, so I'll just close it as it stands. |
|
ok, thanks |
This is the baseline build of code for win_plots, where invalid windows plots were
fixed and the keyboard focus was correctly restored for Linux. The Travis builds
xxx.5, and xxx.10 failed via test_bug_2974380 this is for clang compiled on OSX
systems.
This first commit only submits the repaired devicewin.cpp, .hpp files (which are not used in OSX)
If this passes the next step will be to activate the UnsetFocus() call in WShow.