Added SIGNUM

[GillesDuvert]

closes #1956

[GillesDuvert]

something fussy with all these merge origin/master that seem sticky. And the authoring by gildas@localhost is strange too. Keeping fingers crossed.

[slayoo]

something fussy with all these merge origin/master that seem sticky. And the authoring by gildas@localhost is strange too. Keeping fingers crossed.

@GillesDuvert, your fork's master branch has commits that are not on gnudatalanguage/master:

hence all branches branched out of GillesDuvert/master are "out of sync" with the main repo.

It is likely a good idea to force-push your main to a state where there are no commits "behind" or "ahead" of gnudatalanguage/master

HTH.

[codecov]

Codecov Report

Attention: Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.

Project coverage is 42.45%. Comparing base (aa9693b) to head (895226a).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/math_fun.cpp	0.00%	40 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
- Coverage   42.47%   42.45%   -0.02%     
==========================================
  Files         444      444              
  Lines      110117   110158      +41     
  Branches    22040    22055      +15     
==========================================
+ Hits        46772    46773       +1     
- Misses      63345    63385      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GillesDuvert]

something fussy with all these merge origin/master that seem sticky. And the authoring by gildas@localhost is strange too. Keeping fingers crossed.

@GillesDuvert, your fork's master branch has commits that are not on gnudatalanguage/master hence all branches branched out of GillesDuvert/master are "out of sync" with the main repo.

It is likely a good idea to force-push your main to a state where there are no commits "behind" or "ahead" of gnudatalanguage/master

HTH.

@slayoo ahem, I'm using the git interface of NetBeans and I do not see a button 😄 to do that. Should a simple git command do it? and what command?

[GillesDuvert]

And @slayoo is it OK to squash/merge this PR or shall I redo it after force-pushing my main with this mysterious git command?

[slayoo]

And @slayoo is it OK to squash/merge this PR or shall I redo it after force-pushing my main with this mysterious git command?

Since we are squash-merging, there is no difference.

[slayoo]

@slayoo ahem, I'm using the git interface of NetBeans and I do not see a button 😄 to do that. Should a simple git command do it? and what command?

Assuming we have an upstream remote defined (i.e., git remote add upstream [email protected]:gnudatalanguage/gdl.git), this should do:

git fetch upstream
git switch main
git rebase upstream/main
git push -f

(I've checked and all the contents of the "ahead" commits on your master branch are already effectively part of gnudatalanguage/gdl:master, but there must have been a PR from your master branch, so a squash-merge left your master branch in the "ahead" state)

The rebase part of the above set of commands will try to apply the 8 "ahead" commits one-by-one onto the remote's master:master...GillesDuvert:gdl:master

After the push -f, the `master should be in-sync.

A key pattern that will make sure the above is not needed anymore in future is to:

• always start a branch from master
• never commit to master

HTH, best!
S.

[GillesDuvert]

yes it may have happened I made a PR from the master, 😊 😊

[GillesDuvert]

@slayoo Except that I needed to create a ssh key in GitHub to do the job, all this worked perfectly well, thanks to our team git expert!