SMOOTH with ots of NaNs in the 2d case: closes issue #1940 #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only one where an additionnal array (tmp) was used -- the value returned would come from an uninitialized tmp value (and be wrong). Initializing the tmp array with NaN suffices for obtianing the result.
GillesDuvert
deleted the
close_1940_wrong_values_in_smooth_with_all_nans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when all considered values for smooth were NaN, in the 2D case -- the only one where an additionnal array (tmp) was used -- the value returned may come from an uninitialized tmp value (and be wrong).
Initializing the tmp array with NaN suffices for obtianing the result.