Skip to content

Fixes to netCDF4 and hdf5 #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

rsiddans
Copy link
Contributor

@rsiddans rsiddans commented Nov 28, 2024

Fixes to add missing NetCDF4 datatypes and fix bug reading some float types in HDF5

@rsiddans
Copy link
Contributor Author

Related to issue #1922 and #1923

@rsiddans
Copy link
Contributor Author

Also note I included the code change suggested in #1744 to hdf_fun.cpp, so that it can read (a single) variable length string.

There will remain limitations in both hdf and netcdf for reading arrays of strings (as opposed to char) - however I think string arrays are unusual to find in netcdf files. (Scalar strings attributes are very common though and these can now be read with these changes.)

@rsiddans
Copy link
Contributor Author

rsiddans commented Nov 28, 2024

Actually a couple of other changes are included in this code:

  • keywords gzip+shuffle are added to ncdf_vardef (allowing internal compression to be enabled)
  • there is a fix in map_proj_init.pro to remove a limit of 80 degrees, which should not apply to the default map projection (cylindrical) - In IDL by default map_set gives a map covering the full globe to +/-90 deg. The 80 degree limit is relevant for the mercator projection.

@GillesDuvert
Copy link
Contributor

@rsiddans please remove plplot_config.h and plDevs.h from your PR. They should not be here, and I've no obvious mean to remove them .

@GillesDuvert
Copy link
Contributor

and thanks!

@GillesDuvert
Copy link
Contributor

@rsiddans sorry, I found how to delete the 'offending files' from here.

@rsiddans
Copy link
Contributor Author

@rsiddans sorry, I found how to delete the 'offending files' from here.

OK thanks - sorry not sure why those files were there & many thanks again for all the help.

@GillesDuvert
Copy link
Contributor

@rsiddans additionnal thanks to have spotted the map_set problem.

@GillesDuvert GillesDuvert merged commit 430c1ee into gnudatalanguage:master Nov 28, 2024
7 checks passed
@rsiddans rsiddans deleted the new_branch branch November 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants