-
Notifications
You must be signed in to change notification settings - Fork 63
Fixes to netCDF4 and hdf5 #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…at data types in HDF5 Updated my e-mail
Also note I included the code change suggested in #1744 to hdf_fun.cpp, so that it can read (a single) variable length string. There will remain limitations in both hdf and netcdf for reading arrays of strings (as opposed to char) - however I think string arrays are unusual to find in netcdf files. (Scalar strings attributes are very common though and these can now be read with these changes.) |
Actually a couple of other changes are included in this code:
|
@rsiddans please remove plplot_config.h and plDevs.h from your PR. They should not be here, and I've no obvious mean to remove them . |
and thanks! |
@rsiddans sorry, I found how to delete the 'offending files' from here. |
OK thanks - sorry not sure why those files were there & many thanks again for all the help. |
@rsiddans additionnal thanks to have spotted the map_set problem. |
Fixes to add missing NetCDF4 datatypes and fix bug reading some float types in HDF5