New poly 2d #1919
Merged
New poly 2d #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…language#1909 (Use Floats for coordinates) 3) much improved speed ! rewrite congrid to use poly_2d similarly to IDL. Removed all tentatives to 'do better' (with dimensions). separate poly_2d from math_fun_jmg add poly_2d basic test
|
Apparently a problem with OSX... |
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
==========================================
- Coverage 43.97% 42.09% -1.88%
==========================================
Files 405 442 +37
Lines 98850 109828 +10978
Branches 20043 21979 +1936
==========================================
+ Hits 43465 46236 +2771
- Misses 55385 63592 +8207 ☔ View full report in Codecov by Sentry. |
|
I have acces to a mac OS 15.1 (Sequoia) and all the tests are OK. Do no understand why it does no pass on GH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1909 proved there was a problem in POLY_2D
furthermore there semed to be a speed issue with this command.
This is a rewriting of POLY_2D with special attention to 'border' values for 0 and linear interpolation ( TBC for cubic interpolation) with massive speed gains.
Added a preliminary test file.
Rewrote CONGRID.PRO to use POLY_2 as IDL does.
Plus a small add in basic_pro.cpp (start to make PREF_SET useful)