Skip to content

All cases of FFT are now supported by fftw.cpp #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

GillesDuvert
Copy link
Contributor

All cases of FFT are now supported by fftw.cpp
GDL FFTW now ONLY when FFTW library is present. (old slow GSL code removed)

All cases of FFT are now supported by fftw.cpp
@GillesDuvert
Copy link
Contributor Author

hm thanks to test...

…ig" arrays was not conserved after use of ##= ) --- that's why our coverage of basic functions was not complete!
…: "If the CENTER keyword is also set, then only the dimension given by the DIMENSION keyword is shifted to the center. The other dimensions remain unshifted."

This is NOT WHAT IDL DOES. Bug report to IDL? Or reproduce?
@GillesDuvert
Copy link
Contributor Author

OK. But now we have a problem:
According to FFT documentation: "If the CENTER keyword is also set, then only the dimension given by the DIMENSION keyword is shifted to the center. The other dimensions remain unshifted."

This is NOT WHAT IDL DOES. (but GDL does, now)
Proof:
plot,ABS(FFT(FINDGEN(100,10),dim=1,/cen))
if the 2nd dimension is not shifted (as per the documentation) then the centered peaks should be in linear increasing order. This is true for GDL, but in IDL the peaks have been clearly shifted on the x-axis.

Bug report to IDL? Or reproduce this "feature" in GDL?

@GillesDuvert
Copy link
Contributor Author

see #1898 . Our functionality did not change. good.

@GillesDuvert GillesDuvert merged commit 818856e into gnudatalanguage:master Nov 1, 2024
5 of 7 checks passed
@GillesDuvert GillesDuvert deleted the fftw_wins_all branch December 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant