better widget user experience, on OSX in particular. And a few bugs cured. #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widget loop mamangement strange on OSX (extremely slow in some cases) --- why? not related to Readline as behaviour same without.
…event are performed AFTER widget_event is returned. Fluidize events and widgets responsiveness events returned are conform to what IDL expects
…when needed, and found that WIDGET_EVENT was returning events AFTER event processing, not before. This was the sole reason of gnudatalanguage#1685. Thus removed the unnecessary (and wrong) patch made in 1716 HANDLER is now 0 in all structures created by widgets events, to be updated eventually by user event_pro or event_func. wxLoop is called way more frequently than before, at times when it is needed, widgets shoudl be more reactive.
GillesDuvert
changed the title
Removed wxEVT_COMMAND_MENU_SELECTED to avoid duplicate events (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the 2 different codes between OSX and other platforms (with a small exception for the MenuBar), Menubars now are the same in unix, windows and OSX, and permit teh same button functionality as IDL (fancy fonts, images).
Yield() is still the unique way to have widgets going on OSX, the standard way of creating a wxApp does not work there. Conversely, using only Yield() instead of having mgGDlApp run a loop, is not working on Windows. Go figure.
widget responsiveness was extremely slow on OSX when an action here (ex: cursor on ATV) generates a change in another wxWindow, and more so if that window is in another topFrame ( OSX focus changes!)!!
This PR greatly improves things but is not 100% satisfactory. Probably sign that Yield() is not the good way to handle our wxwidgets inner loop, should make the step and use threads?
WIDGET_EVENT was found wrong in the sense that it used the same eventloop treatment as the 'always active' eventloop. But WIDGET_EVENT should just report the event, not call event handlers. Hopefully this new version is better. At least it satisfactorily solves #1685 without ugly #1716 patch