Skip to content

Adress problem reported in #1852 #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

GillesDuvert
Copy link
Contributor

No description provided.

…he loop number did not start at 0 but at 32 (the initialized defulat size), and would be constantly increasing in size at each new level of nested loop. May even had an incidence on the loop speed."

This reverts commit ebfa961.
@GillesDuvert
Copy link
Contributor Author

hm hdf5 regression...

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.55%. Comparing base (e1d7f28) to head (2c20d73).
Report is 37 commits behind head on master.

Files Patch % Lines
src/hdf5_fun.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
- Coverage   43.89%   43.55%   -0.34%     
==========================================
  Files         376      403      +27     
  Lines       97442    98360     +918     
  Branches    19888    19950      +62     
==========================================
+ Hits        42769    42843      +74     
- Misses      54673    55517     +844     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit 9e6eba3 into gnudatalanguage:master Jul 16, 2024
8 of 9 checks passed
GillesDuvert added a commit that referenced this pull request Jul 17, 2024
GillesDuvert added a commit to GillesDuvert/gdl that referenced this pull request Jul 17, 2024
@GillesDuvert GillesDuvert deleted the deal_with_1852 branch December 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant