Skip to content

Cmakefix #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Cmakefix #1850

merged 3 commits into from
Jul 16, 2024

Conversation

ChunkyPanda03
Copy link
Contributor

I found a couple of errors while compiling I saw that this project uses imagemagick-7 not imagemagick-6 as shown here ##1578 (comment) and I think the reason it is not automatically looking for the correct version. I have added it into the the FindImageMagick. Also a slight note that debian 12 has only imagemagick-6 and cmake recommends that you install it.

test_dynamic_drivers.pro had an error that would prevent the test from setting the resolution which I think was not exiting correctly I now have a few plotting tests failing now but I think this is a personal dependency issue I would like to personally resolve before discussing further.

For the git ignore these files were added to the working directory by the setup script you can choose whether to keep this change or not.

@GillesDuvert
Copy link
Contributor

@ChunkyPanda03 thanks for the PR, just a doubt: you changed set_resolu to set_resolution in test_dynamic_drivers but there should have been no error there, the abbreviation was long enough to avoid confusion?

@GillesDuvert GillesDuvert merged commit 49ae092 into gnudatalanguage:master Jul 16, 2024
6 of 7 checks passed
@ChunkyPanda03
Copy link
Contributor Author

yeah @GillesDuvert I realized that set_resolution is the same as the default it was likely failing for me because of a dependency issue when building on my machine... still tracking that one down.

@ChunkyPanda03 ChunkyPanda03 deleted the cmakefix branch July 31, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants