correcting #1837 PTRARR() #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alaingdl, let's add a unit test for this change! What would be a minimal code to show the problem (i.e., failing as of now, succeeding after this change is introduced?) |
|
@slayoo yes your are right but I am so short in time next days ... Usually when I start a small test code then I find another detail (or bug) somewhere and so on and never succeed to close .. @jaymurthy it should help for your problem interesting that a new test case crashed in OSX ... |
|
OK, my correction is wrong and we did had a test case ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hum, my mistake