Skip to content

Exact plot positioning in all cases #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GillesDuvert
Copy link
Contributor

this incidentally solves #1649

This PR aims at making ALL box, axis and label quite precisely at the same place and size than the idl's ones. Whatever the device, font, character size, use of those so many tick options (tickname, tickv, tickformat, tickunit, ticks, ticklayout, style etc)
Corrects in passing a few errors found during tests.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 241 lines in your changes are missing coverage. Please review.

Comparison is base (d248356) 41.07% compared to head (bd58fae) 41.48%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
+ Coverage   41.07%   41.48%   +0.41%     
==========================================
  Files         356      356              
  Lines       95061    95161     +100     
  Branches    19539    19565      +26     
==========================================
+ Hits        39045    39478     +433     
+ Misses      56016    55683     -333     
Files Coverage Δ
src/basic_pro.cpp 47.97% <100.00%> (+4.36%) ⬆️
src/calendar.cpp 77.94% <100.00%> (+45.58%) ⬆️
src/deviceps.hpp 82.63% <100.00%> (ø)
src/devicesvg.hpp 53.04% <100.00%> (ø)
src/devicez.hpp 70.68% <100.00%> (ø)
src/gdlgstream.hpp 59.45% <ø> (+1.52%) ⬆️
src/libinit.cpp 100.00% <100.00%> (ø)
src/plotting.hpp 100.00% <ø> (ø)
src/plotting_contour.cpp 55.73% <ø> (-0.11%) ⬇️
src/plotting_plot.cpp 59.18% <ø> (-0.21%) ⬇️
... and 6 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit f3fdb3d into gnudatalanguage:master Nov 12, 2023
@GillesDuvert GillesDuvert deleted the exact_plot_positioning_in_all_cases branch July 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant