-
Notifications
You must be signed in to change notification settings - Fork 63
Exact plot positioning in all cases #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GillesDuvert
merged 19 commits into
gnudatalanguage:master
from
GillesDuvert:exact_plot_positioning_in_all_cases
Nov 12, 2023
Merged
Exact plot positioning in all cases #1664
GillesDuvert
merged 19 commits into
gnudatalanguage:master
from
GillesDuvert:exact_plot_positioning_in_all_cases
Nov 12, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…title is at good place.
…-axis modes, be exactly at the same place as in IDL's counterpart. Due to the use of the too-smart plplot 'box' command, an incredible number of detouts are used to cajole plplot or oveeride its code. This does not make our code very readable and maintainable alas.
…total(a*b) when sum values loop in the float range, which was the case with max(a)=255.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
+ Coverage 41.07% 41.48% +0.41%
==========================================
Files 356 356
Lines 95061 95161 +100
Branches 19539 19565 +26
==========================================
+ Hits 39045 39478 +433
+ Misses 56016 55683 -333
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this incidentally solves #1649
This PR aims at making ALL box, axis and label quite precisely at the same place and size than the idl's ones. Whatever the device, font, character size, use of those so many tick options (tickname, tickv, tickformat, tickunit, ticks, ticklayout, style etc)
Corrects in passing a few errors found during tests.