Skip to content

reverted for_block to historical version #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

GillesDuvert
Copy link
Contributor

solves #1599 and #1608.
#52 should be reactivated.

@GillesDuvert
Copy link
Contributor Author

hm. a file is not up-to-date

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 87.13% and project coverage change: -0.01% ⚠️

Comparison is base (b56c2a0) 41.12% compared to head (b82c49c) 41.11%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
- Coverage   41.12%   41.11%   -0.01%     
==========================================
  Files         354      354              
  Lines       94851    94830      -21     
  Branches    19468    19463       -5     
==========================================
- Hits        39007    38991      -16     
+ Misses      55844    55839       -5     
Files Changed Coverage Δ
src/GDLParser.hpp 75.00% <ø> (ø)
src/GDLParser.cpp 66.23% <82.50%> (+0.14%) ⬆️
src/GDLLexer.cpp 68.62% <96.29%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert
Copy link
Contributor Author

merging.
Will have to find why tests crash on Windows, of course they do not on my (virtual) machine.

@GillesDuvert GillesDuvert merged commit 486d2a5 into gnudatalanguage:master Aug 8, 2023
@GillesDuvert GillesDuvert deleted the correct_oops_1608 branch September 8, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant