Skip to content

congrid was complaining if last dimension was 1 #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

GillesDuvert
Copy link
Contributor

@GillesDuvert GillesDuvert merged commit 251e8f9 into gnudatalanguage:master Mar 1, 2023
@slayoo
Copy link
Member

slayoo commented Mar 2, 2023

Kudos for including a new test case!

@alaingdl
Copy link
Contributor

alaingdl commented Mar 2, 2023

yes !

but I would like some/most tests in : spawn_is_dangerous/ and interactive_tests/ go back to testsuite/ because they are useful, and few are now broken (regression) and we forgot to test them.

For SPAWN, for me it is not a problem since it is usage in given contexts we wrote.
For "interactives" and graphics" we may change some outputs to Z or PNG but it is useful to run them

@GillesDuvert
Copy link
Contributor Author

@acoulais of course the interactive and span_is_dangerous tests are badly needed. Just insure they work on builds without displays, or X11 and that spawn commands are those understood by the OS, windows in particular. See #1465 for a recent example.

@GillesDuvert GillesDuvert deleted the patch_congrid branch September 8, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants