Skip to content

world_map fixes for 1.18 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

random-j-farmer
Copy link
Contributor

A relatively clean fix for the 1.18 breakage.

Fixes #280

Still works in 1.17.1, I did not test with older versions because I deleted my old mod folders at one point.

For the new biomes, I just copied configuration for existing, somewhat similiar biomes.

global_biome_data:'meadow' = global_biome_data:'plains';
global_biome_data:'grove' = global_biome_data:'taiga_hills';
global_biome_data:'snowy_slopes' = global_biome_data:'snowy_mountains';
global_biome_data:'jagged_peaks' = global_biome_data:'snowy_mountains';
global_biome_data:'stony_peaks' = global_biome_data:'mountains';

This does not add visual markers for the new features (Lush & Dripstone Caves, Geodes, ...). I would like to have that,
but I also want to play the game this weekend ;)

@Firigion Firigion added the app-update Updates an app label Jan 9, 2022
@altrisi altrisi added the tech-debt Something is no longer working or will stop working Soon™ label Mar 6, 2022
@altrisi altrisi requested review from altrisi and removed request for altrisi September 22, 2022 17:37
@altrisi
Copy link
Collaborator

altrisi commented Sep 22, 2022

Note for future reviewers (incl. self): biome(<biome>, 'category') has been removed in 1.19, so to properly test this you need to run on 1.18(.2 quite sure would work too). 1.19 compat can be looked into later, it shouldn't block this.

BTW sorry about being super slow with PRs! Thanks for contributing even if it's not in yet!

Copy link
Collaborator

@Ghoulboy78 Ghoulboy78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for 1.18.2, but might as well have it for people who still want it

@Ghoulboy78 Ghoulboy78 requested a review from altrisi February 13, 2023 18:16
Copy link
Collaborator

@rv3r rv3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors mentioned in issue seem to be fixed. New biomes seem to work fine (as far as I can tell). I can approve if we don't care who does it and just want someone to do it.

I've never used this script, so I never knew this was (or maybe just is) the longest script in here by leaps and bounds. Additionally, I love it when my game pauses for an entire minute while generating the map. Maybe I should've tested this on my home computer...

On the topic of 1.19.4 update, anyone wanna do it? Or do we just start on the 1.20 version to get that out on time unlike this year old pull?

@Ghoulboy78
Copy link
Collaborator

It doesn't work in any version above 1.18.2, cos certain key features were removed. For higher versions it would likely have to be rewritten entirely.

@rv3r
Copy link
Collaborator

rv3r commented Feb 13, 2023

It doesn't work in any version above 1.18.2, cos certain key features were removed. For higher versions it would likely have to be rewritten entirely.

Yep I figured as much.

1.19 compat can be looked into later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-update Updates an app tech-debt Something is no longer working or will stop working Soon™
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World Map breaks in 1.18
5 participants