-
Notifications
You must be signed in to change notification settings - Fork 169
world_map fixes for 1.18 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Note for future reviewers (incl. self): BTW sorry about being super slow with PRs! Thanks for contributing even if it's not in yet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's for 1.18.2, but might as well have it for people who still want it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors mentioned in issue seem to be fixed. New biomes seem to work fine (as far as I can tell). I can approve if we don't care who does it and just want someone to do it.
I've never used this script, so I never knew this was (or maybe just is) the longest script in here by leaps and bounds. Additionally, I love it when my game pauses for an entire minute while generating the map. Maybe I should've tested this on my home computer...
On the topic of 1.19.4 update, anyone wanna do it? Or do we just start on the 1.20 version to get that out on time unlike this year old pull?
It doesn't work in any version above 1.18.2, cos certain key features were removed. For higher versions it would likely have to be rewritten entirely. |
Yep I figured as much.
|
A relatively clean fix for the 1.18 breakage.
Fixes #280
Still works in 1.17.1, I did not test with older versions because I deleted my old mod folders at one point.
For the new biomes, I just copied configuration for existing, somewhat similiar biomes.
This does not add visual markers for the new features (Lush & Dripstone Caves, Geodes, ...). I would like to have that,
but I also want to play the game this weekend ;)