Update image dependency from 0.23 to 0.24 #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # src/image.rs
kirdaybov
commented
Feb 19, 2022
| DynamicImage::ImageLuma16(_) => Format::R16, | ||
| DynamicImage::ImageLumaA16(_) => Format::R16G16, | ||
| DynamicImage::ImageRgb16(_) => Format::R16G16B16, | ||
| DynamicImage::ImageRgba16(_) => Format::R16G16B16A16, | ||
| DynamicImage::ImageRgb32F(_) => Format::R32G32B32FLOAT, | ||
| DynamicImage::ImageRgba32F(_) => Format::R32G32B32A32FLOAT, | ||
| _ => unreachable!("Unmatched DynamicImage format"), |
There was a problem hiding this comment.
enum DynamicImage is #[non_exhaustive] since 0.24
|
Thank you! |
alteous
reviewed
Feb 27, 2022
Comment on lines
-148
to
-149
| DynamicImage::ImageBgr8(_) => Format::B8G8R8, | ||
| DynamicImage::ImageBgra8(_) => Format::B8G8R8A8, |
There was a problem hiding this comment.
Why have these cases been removed?
There was a problem hiding this comment.
They have been removed from the DynamicImage of the image crate. You can take a look at the corresponding discussions image-rs/image#1482 image-rs/image#1671
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building our repository that depends on
gltfwe found out that it is not using the lastimagecrate. We would appreciate if the dependency could be brought up to date.