Skip to content

Add Cython pyx, pxd, pxi files to MANIFEST.in #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Conversation

bdice
Copy link
Member

@bdice bdice commented Sep 9, 2020

Description

The release of freud 2.3.0 failed on conda-forge with the PyPI tarball: conda-forge/freud-feedstock#30

The root cause is that freud's MANIFEST.in did not include Cython *.pyx and *.pxd files in the source distribution, meaning that the source distribution did not detect the Cython modules and could not build. Luckily the tarball hosted at http://glotzerlab.engin.umich.edu/Downloads/freud/ included these files, allowing for a build that is still nearly-canonical (building from the PyPI tarball would have been preferable because the PyPI tarball is smaller and consistent with the released PyPI builds).

Motivation and Context

Fixes conda-forge builds for the future.

How Has This Been Tested?

Tested locally by verifying the outputs of python setup.py sdist.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@bdice bdice added bug Something isn't working building & installation labels Sep 9, 2020
@bdice bdice added this to the v2.4 milestone Sep 9, 2020
@bdice bdice requested a review from a team September 9, 2020 04:33
@bdice bdice self-assigned this Sep 9, 2020
@bdice bdice requested a review from tommy-waltmann September 9, 2020 04:33
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdice bdice merged commit cc0c168 into master Sep 9, 2020
@bdice bdice deleted the fix/sdist-pyx branch September 9, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working building & installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants