Add Cython pyx, pxd, pxi files to MANIFEST.in #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The release of freud 2.3.0 failed on conda-forge with the PyPI tarball: conda-forge/freud-feedstock#30
The root cause is that freud's
MANIFEST.in
did not include Cython*.pyx
and*.pxd
files in the source distribution, meaning that the source distribution did not detect the Cython modules and could not build. Luckily the tarball hosted at http://glotzerlab.engin.umich.edu/Downloads/freud/ included these files, allowing for a build that is still nearly-canonical (building from the PyPI tarball would have been preferable because the PyPI tarball is smaller and consistent with the released PyPI builds).Motivation and Context
Fixes conda-forge builds for the future.
How Has This Been Tested?
Tested locally by verifying the outputs of
python setup.py sdist
.Types of changes
Checklist: