actions, pull_request: Check reward weight correctly on outdated branch #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-sbi
force-pushed
the
stas/actions_pull_request_check_total_reward_weight_correctly_on_outdated_branch
branch
from
16879e4 to
b432660
Compare
- Compare PR branch with merged main against main instead of comparing original PR branch with main to get predictable results when PR branch is stale
stas-sbi
force-pushed
the
stas/actions_pull_request_check_total_reward_weight_correctly_on_outdated_branch
branch
from
13569ab to
1464853
Compare
tkatrichenko
approved these changes
May 13, 2025
stas-sbi
deleted the
stas/actions_pull_request_check_total_reward_weight_correctly_on_outdated_branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixed cases like this one where total reward weight hasn't changed but the check resulted in failure