Skip to content

Consolidate recent theme change docs in THEMES.md #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 22, 2025

Conversation

naseschwarz
Copy link
Contributor

@naseschwarz naseschwarz commented Mar 20, 2025

This pull request consolidates #2570, #2214, #2564 (via #2573) into a single pull. The result from just merging seemed random, this adds a bit more structure to the document.

It changes the following:

I followed the checklist:

  • Checked the THEMES.md rendering on github.
  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@naseschwarz naseschwarz force-pushed the themes-doc-complete branch 2 times, most recently from 0ab17da to 5b11cdd Compare March 20, 2025 11:44
@naseschwarz naseschwarz force-pushed the themes-doc-complete branch from 5b11cdd to b0fe8ed Compare March 20, 2025 11:47
@naseschwarz naseschwarz changed the title Themes doc complete Consolidate recend theme change docs in THEMES.md Mar 20, 2025
@naseschwarz naseschwarz changed the title Consolidate recend theme change docs in THEMES.md Consolidate recent theme change docs in THEMES.md Mar 20, 2025
@naseschwarz naseschwarz force-pushed the themes-doc-complete branch from b0fe8ed to 83ff734 Compare March 20, 2025 11:50
@naseschwarz
Copy link
Contributor Author

@VasilisManol: I picked your change from #2570 and extended it about the changes for #2564 to streamline merging this.

@acuteenvy, @VasilisManol: If you could find the time, I'd appreciate any feedback you might have.

Copy link
Contributor

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, just some minor nitpicks

@naseschwarz
Copy link
Contributor Author

Thanks, @acuteenvy, I appreciate it!

@naseschwarz
Copy link
Contributor Author

@extrawurst: I'll be a bit forward and add the "merge ready" label on my own PR here. Hope that's alright.

@extrawurst extrawurst merged commit 6a884d1 into gitui-org:master Mar 22, 2025
21 checks passed
@extrawurst
Copy link
Collaborator

Lgtm! Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants