-
-
Notifications
You must be signed in to change notification settings - Fork 605
Consolidate recent theme change docs in THEMES.md #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ab17da
to
5b11cdd
Compare
5b11cdd
to
b0fe8ed
Compare
b0fe8ed
to
83ff734
Compare
@VasilisManol: I picked your change from #2570 and extended it about the changes for #2564 to streamline merging this. @acuteenvy, @VasilisManol: If you could find the time, I'd appreciate any feedback you might have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM, just some minor nitpicks
Co-authored-by: Lena <[email protected]>
Co-authored-by: Lena <[email protected]>
Thanks, @acuteenvy, I appreciate it! |
@extrawurst: I'll be a bit forward and add the "merge ready" label on my own PR here. Hope that's alright. |
Lgtm! Thanks 🙏 |
This pull request consolidates #2570, #2214, #2564 (via #2573) into a single pull. The result from just merging seemed random, this adds a bit more structure to the document.
It changes the following:
I followed the checklist:
I added unittestsI ranmake check
without errorsI tested the overall applicationI added an appropriate item to the changelog