Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow customising key symbols #465

Closed
extrawurst opened this issue Dec 26, 2020 · 3 comments · Fixed by #997
Closed

allow customising key symbols #465

extrawurst opened this issue Dec 26, 2020 · 3 comments · Fixed by #997
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.19

Comments

@extrawurst
Copy link
Collaborator

#464 showed that we should allow overwriting/customizing the symbols we use to show key codes. this can be added similarly to our general key configuration in keys.rs see get_key_symbol
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2020
extrawurst pushed a commit that referenced this issue Dec 26, 2020
single lookup place for key symbols in preperation for #465
24758d4
@extrawurst extrawurst mentioned this issue Dec 26, 2020
Closed
@josmith42
Copy link

I think I'd like to take a stab at this.

Question: in addition to implementing the feature, would you like the PR to also update the key config documentation so users know how to customize the symbols?

@josmith42 josmith42 mentioned this issue Feb 13, 2021
Closed
@stale stale bot added the wontfix This will not be worked on label May 14, 2021
@extrawurst extrawurst removed the wontfix This will not be worked on label May 14, 2021
@gitui-org gitui-org deleted a comment from stale bot May 14, 2021
extrawurst pushed a commit that referenced this issue May 27, 2021
single lookup place for key symbols in preperation for #465
efcd5ea
@stale stale bot added the dormant Marked by stale bot on close label Aug 12, 2021
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Aug 12, 2021
@gitui-org gitui-org deleted a comment from stale bot Aug 12, 2021
@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the dormant Marked by stale bot on close label Nov 10, 2021
@stale stale bot closed this as completed Nov 18, 2021
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Nov 20, 2021
@extrawurst extrawurst reopened this Nov 20, 2021
@extrawurst extrawurst mentioned this issue Nov 20, 2021
Merged
@extrawurst extrawurst added this to the v0.19 milestone Nov 20, 2021
@extrawurst extrawurst mentioned this issue Nov 20, 2021
Closed
extrawurst pushed a commit that referenced this issue Nov 20, 2021
allow config for key symbols (#997)
3db1a68 
closes #465
@extrawurst
Copy link
Collaborator Author

docs for this: https://github.com/extrawurst/gitui/blob/master/KEY_CONFIG.md#key-symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.19
Development

Successfully merging a pull request may close this issue.

Config key symbols gitui-org/gitui
2 participants
@extrawurst @josmith42