Skip to content

make test fails on windows #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pm100 opened this issue Oct 19, 2023 · 0 comments
Open

make test fails on windows #1932

pm100 opened this issue Oct 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pm100
Copy link
Contributor

pm100 commented Oct 19, 2023

#1751 adds a test that makes symbolic links.

This fails on windows unless you are 'root' - see https://doc.rust-lang.org/stable/std/os/windows/fs/fn.symlink_file.html#limitations

This means that anybody on windows has to diagnose why this test fails, which is not obvious. (No normal dev on windows runs as root, just like on linux etc. Note that the github ci tasks works, so they must be running with the correct rights)

Maybe just having this bug report is enough to help out as google will find it. Alternatives:

  • detect the 'not enough rights' failure and end the test as successful
  • look for lack of root and exit the test early
  • doc in readme under the 'build' section.
@pm100 pm100 added the bug Something isn't working label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant