key_bindings.ron should follow symlink

[okuramasafumi]

Describe the bug

When I use symlink to configure key bindings like below, it didn't work.

ln -s ~/dotfiles/git/gitui/keyconfig.ron ~/.config/gitui/keyconfig.ron

When I use cp instead of ln -s it worked.

To Reproduce
Steps to reproduce the behavior:

1. Create key_bindings.ron somewhere (say, ~/key_bindings.ron)
2. ln -s ~/keyconfig.ron ~/.config/gitui/keyconfig.ron
3. Confirm that it is not applied

Expected behavior

Symlink should work.

Context (please complete the following information):

• OS/Distro + Version: macOS 13.4.1
• GitUI Version 0.23.0
• Rust version: None (installed via Homebrew)

Additional context

I tried to use symlink since I wanted to put my config in my dotfiles. This could be pretty common.

[Muttsuri]

It's a hacky solution for now, but couldn't you use hard-links ?
I'm not familiar with macOS but given it's UNIX based it should work similarly, no ?
Short and clear soft-link vs hard-link difference, post here. And according to this macOS thread, you could create your hard-link with:

ln ~/dotfiles/git/gitui/keyconfig.ron ~/.config/gitui/keyconfig.ron

(yes it's just killing the -s soft-link flag)

I agree that it should be able to follow symlinks just but it might help you for now I hope 🙂

[extrawurst]

Should be easy to fix using https://doc.rust-lang.org/std/fs/fn.canonicalize.html on the file-path. should be unittestable

[TheBlackSheep3]

Hey! Is this issue already assigned to someone? If not, I would like to work on it.

[extrawurst]

We don’t assign. You make a PR and that’s it :)

[TheBlackSheep3]

Thanks. Will do :)