Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies #4215

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Update go dependencies #4215

merged 3 commits into from
Jun 15, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 13, 2021 •
edited
Loading

Changes:

  • containerd v1.5.2
  • gorilla/mux v1.8.0
  • docker/docker v20.10.7+incompatible
  • github.com/prometheus/client_golang v1.11.0 (reduces number of dependencies Update Go modules prometheus/client_golang#875)
  • k8s.io/* v0.21.1
  • controller-runtime v0.9.0

@aledbf aledbf force-pushed the aledbf/containerd branch 3 times, most recently from dcac6c3 to 2892db3 Compare May 14, 2021 02:11
@aledbf aledbf force-pushed the aledbf/containerd branch 5 times, most recently from 40c506b to 1fcecbb Compare June 10, 2021 00:07
@aledbf
Copy link
Member Author

aledbf commented Jun 10, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-containerd.14

@aledbf aledbf force-pushed the aledbf/containerd branch from 1fcecbb to 3ac158c Compare June 10, 2021 00:35
@aledbf
Copy link
Member Author

aledbf commented Jun 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-containerd.16

@aledbf aledbf force-pushed the aledbf/containerd branch from 3ac158c to 8b3b1eb Compare June 14, 2021 18:25
@aledbf
Copy link
Member Author

aledbf commented Jun 14, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-containerd.18

@aledbf aledbf marked this pull request as ready for review June 14, 2021 19:00
@aledbf aledbf requested a review from csweichel June 14, 2021 19:00
@aledbf aledbf force-pushed the aledbf/containerd branch from 8b3b1eb to bcf7df6 Compare June 14, 2021 19:55
@gitpod-io gitpod-io deleted a comment from codecov bot Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #4215 (2f901ea) into main (8cc1e52) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4215      +/-   ##
==========================================
+ Coverage   36.83%   37.19%   +0.35%     
==========================================
  Files          74       51      -23     
  Lines       15047    10916    -4131     
==========================================
- Hits         5543     4060    -1483     
+ Misses       9028     6507    -2521     
+ Partials      476      349     -127
Flag Coverage Δ
components-content-service-app ?
components-content-service-lib ?
components-ee-ws-scheduler-app ?
components-image-builder-api-go-lib ?
components-image-builder-app 34.44% <ø> (ø)
components-local-app-app-darwin ?
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 36.95% <ø> (+0.21%) ⬆️
components-workspacekit-app ?
components-ws-daemon-api-go-lib ?
components-ws-daemon-app 22.72% <ø> (ø)
components-ws-daemon-nsinsider-app ?
components-ws-manager-api-go-lib ?
components-ws-manager-app 36.44% <ø> (ø)
components-ws-proxy-app 65.95% <ø> (ø)
dev-loadgen-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/content-service/pkg/storage/namedurl.go
...ponents/ee/ws-scheduler/pkg/scheduler/scheduler.go
components/content-service/pkg/storage/storage.go
...onents/content-service/pkg/initializer/prebuild.go
components/ee/ws-scheduler/pkg/scaler/driver.go
...ts/ee/ws-scheduler/pkg/scheduler/priority-queue.go
components/content-service/pkg/layer/provider.go
components/content-service/pkg/initializer/git.go
components/content-service/pkg/archive/tar.go
components/ee/ws-scheduler/pkg/scheduler/config.go
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc1e52...2f901ea. Read the comment docs.

csweichel
csweichel approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for doing this!

aledbf added 3 commits June 15, 2021 09:24
@aledbf
43f0896 
Update go dependencies
@aledbf
6a24ac7 
Update methods signature
@aledbf
2f901ea 
Update k8s dependencies to v0.21.1
@aledbf aledbf force-pushed the aledbf/containerd branch from bcf7df6 to 2f901ea Compare June 15, 2021 13:26
@aledbf
Copy link
Member Author

aledbf commented Jun 15, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-containerd.21

@aledbf aledbf merged commit 9681a2b into main Jun 15, 2021
@aledbf aledbf deleted the aledbf/containerd branch June 15, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledbf @csweichel