Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare perf: Fix missing unit in grouped predicate entry #3987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compare perf: Fix missing unit in grouped predicate entry #3987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class ComparisonDataset {
}
}

function renderOptionalValue(x: Optional<number>, unit?: string) {
function renderOptionalValue(x: Optional<number>, unit: string | undefined) {
Copy link
Preview

Copilot AI Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the 'unit' parameter is intended to be mandatory as mentioned in the PR description, consider updating its type to 'string' instead of 'string | undefined' and ensure that all call sites provide a valid string.

Suggested change
function renderOptionalValue(x: Optional<number>, unit: string | undefined) {
function renderOptionalValue(x: Optional<number>, unit: string) {

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

switch (x) {
case AbsentReason.NotSeen:
return <AbsentNumberCell>n/a</AbsentNumberCell>;
Expand Down Expand Up @@ -712,8 +712,8 @@ function PredicateRowGroup(props: PredicateRowGroupProps) {
<ChevronCell>
<Chevron expanded={isExpanded} />
</ChevronCell>
{comparison && renderOptionalValue(rowGroup.before)}
{renderOptionalValue(rowGroup.after)}
{comparison && renderOptionalValue(rowGroup.before, metric.unit)}
{renderOptionalValue(rowGroup.after, metric.unit)}
{comparison && renderDelta(rowGroup.diff, metric.unit)}
<NameCell>
{renderedName} ({rowGroup.rows.length} predicates)
Expand Down
Loading