Remove the use of @vscode/webview-ui-toolkit
#3986
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uan-nguen/replace-vscode-webview
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extensions/ql-vscode/src/view/method-modeling/MultipleModeledMethodsPanel.tsx
Fixed
Show fixed
Hide fixed
extensions/ql-vscode/src/view/method-modeling/MultipleModeledMethodsPanel.tsx
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
@vscode/webview-ui-toolkitand replaces it with@vscode-elements/react-elements. The PR could not broken down to smaller PRs because importing both libraries breaks the view tests. Both libraries register similarly named components (e.g.vscode-button) which have conflicting implementations and that causes an error when tests are run.I have created a new component
ActionButtonwhich aims to copy the styles that@vscode/webview-ui-toolkitforVSCodeButtonwhenappearance="icon". I did this because the new library renders the background even when it's an icon button.I have also added a new component
Badgewhich appliesvariant="counter"by default which applies a border-radius to the badge.I have also replaced
getBy*queries withfindBy*in view tests becausegetBy*doesn't seem to load elements with all their attributes; however,findBy*selects elements only when all the attributes have been loaded.