"X years ago" is not rounding correctly

[antn]

I noticed that something from Feb 2020 displayed as "5 years ago", when it is closer to 4 years if we are trying to round?

[Gusted]

Some light investigation suggests that the problem is in roundToSingleUnit (months and days needs to be specified for it to reproduce) likely around this logic, there's no comment here so I'm not sure what this logic is supposed to do. Here's a concrete testcase that currently fails.

diff --git a/test/duration.ts b/test/duration.ts
index ef96d97..e6c6aaf 100644
--- a/test/duration.ts
+++ b/test/duration.ts
@@ -309,6 +309,7 @@ suite('duration', function () {
         },
       ],
       ['-P27D', '-P1M', {relativeTo: new Date('2023-02-28T00:00:00Z')}],
+      [{days: -15, months: -11}, '-P1Y', {relativeTo: new Date('2024-01-06T00:00:00')}],
     ])
     for (const [input, expected, opts] of roundTests) {
       test(`roundToSingleUnit(${input}) === ${expected}`, () => {

[martinburger]

I think I ran into a similar issue:

This screenshot has been taken from a Gitea instance. Gitea uses relative-time-element to display, well, relative dates.

[santeriv]

Yeah seeing similar on 2024-01-15 (not yet 3 years, but it shows 4 years ) compared to real value 2021-02-02 .

Did not make a test case of this..