Laravel: ignore homestead config and npm debug. #2192
Conversation
| @@ -8,9 +8,15 @@ app/storage/ | |||
| # Laravel 5 & Lumen specific | |||
| public/storage | |||
| storage/*.key | |||
| /.idea | |||
There was a problem hiding this comment.
I think this is related to PHPStorm, which we're tracking in Global/JetBrains.gitignore and has more specific rules than just this. Can we drop it?
There was a problem hiding this comment.
It doesn't need to be there, it's just shiped by default with fresh laravel 5.3
There was a problem hiding this comment.
The trailing . in the commit shortlog "Laravel: ignore homestead config and npm debug." is typically not wanted. Think of the first line as a subject of an email. Email subjects typically do not end in a .
And the two commits should be squashed into one commit.
| .env.*.php | ||
| .env.php | ||
| .env | ||
|
|
||
| # Logs |
There was a problem hiding this comment.
Could you make this comment clearer that it's related to the use of Larvel Elixir?
There was a problem hiding this comment.
I made this section to any log files created by system that shouldn't be published.
npm-debug.log for example, created by node.
That file can comes maybe because there was error in laravel-elixir installation.
but it's not related to the app (laravel project). It's system or node.js failure.
|
I merged #2049 which covers the Homestead rule. @Arsfiqball please have a look at the comments about the |
|
I decide to put npm-debug.log with vendor and node_modules. |
|
@Arsfiqball thanks! |
Laravel: ignore homestead config and npm debug.
Reasons for making this change:
About the homestead configurations: /.idea, Homestead.json, Homestead.yaml is provided by default in newest laravel 5.3 installation.
About npm log files: laravel-elixir uses npm. If something happen (e.g failed npm install), then npm will create npm-debug.log.
Links to documentation supporting these rule changes:
https://github.com/laravel/laravel/blob/master/.gitignore
https://github.com/laravel/elixir