Update Rust.gitignore #1942
Merged
Update Rust.gitignore #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to specifically ignore compiled files and executables as it will be under the target directory
|
Is this a recent change in Rust or do we assume most users will be on the right version? |
|
This has been the case for as long as I have known about Rust, which is at least 2 years. Additionally, most Rust projects I've seen and worked on have had gitignores pretty much only consisting of the target directory. |
|
@elifoster cool - if there's a good example elsewhere we can cite I'm happy to run with this change! |
|
There's the issue in the Rust repo that @deepak linked. There is also all the Rust repositories which ignore solely target: |
|
@elifoster excellent, thanks! |
|
thanks @elifoster and @shiftkey |
nitinkgp23
pushed a commit
to nitinkgp23/gitignore
that referenced
this pull request
Oct 8, 2016
Update Rust.gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to specifically ignore compiled files and executables
as it will be under the target directory
this is as per this comment
in the rust repo