-
Notifications
You must be signed in to change notification settings - Fork 83.1k
Ignore ApplicationInsights.config for Microsoft Azure #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ignore Azure ApplicationInsights.config in VisualStudio.gitignore
Windows Azure -> Microsoft Azure. Due to https://azure.microsoft.com/sv-se/blog/upcoming-name-change-for-windows-azure/
@anderslundsgard do you have any links to documentation around this, so that others can understand this requirement? |
Yes, here is a good introduction to ApplicationInsights http://docs.asp.net/en/latest/fundamentals/application-insights.html |
@anderslundsgard and for reference, can you share what sort of stuff is in your created It might also be worth submitting a PR to those docs to explain the cc @ardalis for a 👍 on this PR |
The element I got stuck on was the InstrumentationKey GUID that is your unique key to send statistics of site usage to Azure.
|
@anderslundsgard thanks, I'll get this in and if others decided they have differing opinions we can revisit |
Ignore ApplicationInsights.config for Microsoft Azure
Great, thanks! |
This commit update file state with upstream project. Thanks!
This change breaks continuous deployment from github through the Azure portal. The Azure deployment scripts expect ApplicationInsights.config to be there.
InstrumentationKey isn't a secret. In fact, it's used on client side web pages. |
Ok, I have not experienced that (yet) but then i totally agree with you @gitFurious. |
@gitFurious thanks for bringing this to our attention. I'd gladly take a patch to revert this before the damage goes any further... |
Ignore ApplicationInsights.config for Microsoft Azure
The feature Application Insights in Microsoft Azure is cool but the config file ApplicationInsights.config should not be in version control.
According to https://azure.microsoft.com/sv-se/blog/upcoming-name-change-for-windows-azure/ Windows Azure is also renamed to Microsoft Azure.