Add support for retrieving GitHub Issue Comments #106
+217
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new tool 'get_issue_comments' that allows fetching comments associated with GitHub issues. This complements the existing issue retrieval functionality and follows the same patterns as the pull request comments implementation. The implementation includes: - New getIssueComments function in pkg/github/issues.go - Tool registration in server.go - Comprehensive test coverage in issues_test.go
juruen
requested changes
Apr 5, 2025
pkg/github/issues.go
Outdated
Comment on lines
631
to
635
| opts := &github.IssueListCommentsOptions{ | ||
| ListOptions: github.ListOptions{ | ||
| PerPage: 100, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Please, let's add proper support for pagination. That is, let's make the tool take page, and perPage. Take a look at listCommits if you want to see an example.
To be consistent, use 30 as the default page size.
There was a problem hiding this comment.
🤦 Great catch - I added pagination with a default perPage of 30, and added tests for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tool 'get_issue_comments' that allows fetching comments associated with GitHub issues. This complements the existing issue retrieval functionality and follows the same patterns as the pull request comments implementation.
The implementation includes: