Vitess: include cells filter in Vtctld API call #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes Freno to add a Vitess-cell filter in the call it does to the
vtctld
API to gather tablets. Freno already supports filtering of tablets by cell but this currently happens client-side only. Filtering at thevtctld
API should reduce the overhead ofvtctld
gathering tablet information (across many cells), the size of the response, etcSupport for filtering by cell(s) was added to the Vitess
vtctld
API used by Freno in vitessio/vitess#6569 (Vitess release 8.0.0+)This change is backward-compatible as older Vitess releases will just-ignore the
?cells=
query parameter and we're still filtering by cell client-side (will be deprecated in the future) - so both sides are always filtered 👍Example of the cells filter: