-
Notifications
You must be signed in to change notification settings - Fork 61.8k
Note case-sensitivity of CODEOWERS in CODEOWNERS syntax docs #13708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@chrisgarber |
This comment has been minimized.
This comment has been minimized.
Anything I can do to help move this through? |
@chrisgarber Our small team is working our way through reviewing all of the amazing contributions that were made during the holidays ✨ One of the writers would be reviewing this PR soon. Thanks for your patience! |
sounds good, thanks for your hard work 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR, @chrisgarber! Your changes look great. I've just made a few small changes to the syntax (for example
instead of e.g.
) and to use a liquid reusable for GitHub
.
Thank you for contributing to the GitHub docs and helping clear things up around case sensitivity for CODEOWNERS
files ✨
...ging-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #12760
What's being changed:
Copy on https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners. See auto-comment for staging links for a "live" view.
In addition to the proposed case sensitivity changes, there were two example sections that covered similar content. I combined the two examples into one block.
Check off the following:
Writer impact (This section is for GitHub staff members only):