Update build dependencies, update octokit request #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lseppala
force-pushed
the
lsep/update-dependencies
branch
from
e5aa2e6 to
f6373d2
Compare
lseppala
force-pushed
the
lsep/update-dependencies
branch
from
cf904b2 to
517349f
Compare
This reverts commit 6764bdb.
lseppala
commented
Feb 22, 2023
| @@ -12,6 +12,12 @@ jobs: | |||
| - name: 'Checkout Repository' | |||
| uses: actions/checkout@v3 | |||
| - uses: actions/setup-node@v3 | |||
| # As of 2023-02-22, the ubuntu-latest image uses npm v8.3.1. This version | |||
There was a problem hiding this comment.
I get my developer card back with this one
lseppala
commented
Feb 22, 2023
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "npm-dependency-submission-example", | |||
| "name": "@github/npm-dependency-submission-example", | |||
There was a problem hiding this comment.
A hacker namespace squatted the old name and published malware to npmjs.org with it. Clever! Putting this unpublished package under @github/ prevents future squatting.
pcarlisle
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies (
@vercel/nccin particular) so builds can succeed.octokitwas updated to include some clever typing information based on the endpoint being requested. This required a change in our use of octokit to POST a snapshot.Includes other fixes caused by build-tool bugs.