Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signature of using core.getIDToken #11

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Fix signature of using core.getIDToken #11

merged 2 commits into from
Jun 20, 2022

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jun 18, 2022

sig-before

⬇️

sig-after

@kachick kachick requested a review from a team June 18, 2022 10:57
@kachick kachick changed the title Fix signature of using get id token Fix signature of using core.getIDToken Jun 18, 2022
@febuiles
Copy link

@kachick nice catch, thanks again!

@febuiles febuiles merged commit b82f1b6 into github:main Jun 20, 2022
@kachick
Copy link
Contributor Author

kachick commented Jun 20, 2022

Thank you for merging! 🙏

@kachick kachick deleted the fix-signature-of-using-getIDToken branch June 20, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kachick @febuiles