Skip to content

Fix typo from tommorow to tomorrow #19487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BaseMax
Copy link

@BaseMax BaseMax commented May 13, 2025

Fix typo from tommorow to tomorrow

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 19:13
@BaseMax BaseMax requested review from a team as code owners May 13, 2025 19:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes several spelling typos in various files to improve clarity and consistency.

  • Corrects typo mappings in the CodeQL TypoDatabase
  • Fixes error message typos in JavaScript test
  • Updates Javadoc typos in a Java stub file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
shared/typos/codeql/typos/TypoDatabase.qll Updates typo mappings for "commited", "occured", and "tommorow"
javascript/ql/test/query-tests/Security/CWE-912/tst.js Corrects spelling in error messages written to file and error variable strings
java/ql/test/stubs/jabsorb-1.3.2/org/jabsorb/serializer/ObjectMatch.java Fixes spelling mistakes in Javadoc for mismatched fields
Comments suppressed due to low confidence (8)

java/ql/test/stubs/jabsorb-1.3.2/org/jabsorb/serializer/ObjectMatch.java:45

  • The typo in the Javadoc comment has been corrected from 'occured' to 'occurred'; the update improves documentation clarity.
* @param mismatch the number of mismatched fields that occurred on a tryUnmarshall call.

java/ql/test/stubs/jabsorb-1.3.2/org/jabsorb/serializer/ObjectMatch.java:55

  • The change from 'occured' to 'occurred' in the Javadoc return comment improves readability and accuracy.
* @return the number of mismatched fields that occurred on a tryUnmarshall call.

shared/typos/codeql/typos/TypoDatabase.qll:1828

  • The fix changes the wrong side of the mapping to match the correct spelling; please confirm that mapping a correct word to itself is intentional.
wrong = "committed" and right = "committed"

shared/typos/codeql/typos/TypoDatabase.qll:5560

  • This update corrects 'occured' to 'occurred', making both fields identical; verify that this mapping change meets the intended typo handling.
wrong = "occurred" and right = "occurred"

shared/typos/codeql/typos/TypoDatabase.qll:8334

  • The correction from 'tommorow' to 'tomorrow' is applied; please ensure that the new mapping (with identical values) still fulfills the intended typo detection logic.
wrong = "tomorrow" and right = "tomorrow"

javascript/ql/test/query-tests/Security/CWE-912/tst.js:30

  • The spelling correction for 'error occured' to 'error occurred' improves clarity.
fs.writeFile("/tmp/test", "error occurred"); // OK - static data written to file

javascript/ql/test/query-tests/Security/CWE-912/tst.js:34

  • Corrected the typo in the error message; this update enhances consistency.
let error = "error occurred";

java/ql/test/stubs/jabsorb-1.3.2/org/jabsorb/serializer/ObjectMatch.java:53

  • The spelling fix in the Javadoc comment ensures consistency; 'occured' has been updated to 'occurred'.
* Get the number of mismatched fields that occurred on a tryUnmarshall call.

@owen-mc
Copy link
Contributor

owen-mc commented May 14, 2025

The only appearance of "tommorow" is intended, to catch typos. The other commits have been dealt with in other PRs. So I am closing this PR.

In future, it would be better if all PRs could be independent, not building on each other. I understand this creates a small risk of merge conflicts, but it makes it much easier to review and discuss each PR separately.

@owen-mc owen-mc closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants