Skip to content

Fix typo from occured to occurred #19485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BaseMax
Copy link

@BaseMax BaseMax commented May 13, 2025

Fix typo from occured to occurred

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 18:35
@BaseMax BaseMax requested review from a team as code owners May 13, 2025 18:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a spelling mistake by replacing "occured" with "occurred" in typo mappings and test files.

  • Updated typo mapping in the CodeQL TypoDatabase
  • Corrected spelling in JavaScript test file
  • Corrected spelling in JavaDoc comments in the Java stub file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
shared/typos/codeql/typos/TypoDatabase.qll Updated typo mapping for the "occured" typo
javascript/ql/test/query-tests/Security/CWE-912/tst.js Corrected static error message strings
java/ql/test/stubs/jabsorb-1.3.2/org/jabsorb/serializer/ObjectMatch.java Updated JavaDoc comments to fix the typo
Comments suppressed due to low confidence (1)

shared/typos/codeql/typos/TypoDatabase.qll:5560

  • The mapping now uses the correct spelling for both the wrong and right values. If the intent is to catch the typo, the wrong value should remain as 'occured' so that mistyped strings are properly detected.
wrong = "occurred" and right = "occurred"

@owen-mc
Copy link
Contributor

owen-mc commented May 14, 2025

There are three files with usages of "occured". In one it is deliberate and another file is a stub (i.e. copied from external code, with method bodies removed), so it probably shouldn't be changed. Only the ones in javascript/ql/test/query-tests/Security/CWE-912/tst.js appears to be incorrect and should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants