Skip to content

C#: Add cs/call-to-gc to the code quality suite. #19482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

michaelnebel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C# label May 13, 2025
@michaelnebel michaelnebel marked this pull request as ready for review May 14, 2025 08:19
@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 08:19
@michaelnebel michaelnebel requested a review from a team as a code owner May 14, 2025 08:19
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label May 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the new cs/call-to-gc query into the C# code-quality suite.

  • Include a quality tag in the query metadata for CallToGCCollect.ql.
  • Register the new query in the integration test’s expected list.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
csharp/ql/src/API Abuse/CallToGCCollect.ql Added quality under @tags in the doc comment
csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected Added the new query path to the expected outputs

@michaelnebel
Copy link
Contributor Author

DCA looks good.

@michaelnebel michaelnebel merged commit ef4c921 into github:main May 14, 2025
26 of 27 checks passed
@michaelnebel michaelnebel deleted the csharp/code-quality-call-to-gc branch May 14, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants