Skip to content

Rust: Update some inline expectation comments #18856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Feb 25, 2025

#18847 follow-up.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Feb 25, 2025
@hvitved hvitved marked this pull request as ready for review February 25, 2025 08:38
@Copilot Copilot AI review requested due to automatic review settings February 25, 2025 08:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates inline expectation comments in Rust library tests to correct and improve consistency based on the follow-up from PR #18847.

  • Updated inline expectation comments from the "$ MISSING: item=…" format to the expected "$ item=…" format
  • Adjusted several annotation comments in test cases to ensure they align with the established patterns

Reviewed Changes

File Description
rust/ql/test/library-tests/path-resolution/main.rs Updated inline expectation comments for improved consistency and accuracy

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

rust/ql/test/library-tests/path-resolution/main.rs:184

  • [nitpick] The inline expectation comment here is inconsistent with surrounding entries; consider updating '52' to 'I52' for uniformity with other expectation items.
> // $ MISSING: item=52

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@hvitved hvitved requested a review from redsun82 February 25, 2025 09:46
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@hvitved hvitved merged commit 0522f3f into github:main Feb 25, 2025
13 checks passed
@hvitved hvitved deleted the rust/inline-expectations-update branch February 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants