Skip to content

C++: Consider writes to arrays as uncertain #18251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

MathiasVP
Copy link
Contributor

This PR fixes a bug where we were incorrectly concluding that a write such as:

int xs[10];
*xs = 42;

would overwrite the entire object.

Commit-by-commit review recommended (even though the fix is extremely straightforward).

@MathiasVP MathiasVP requested a review from a team as a code owner December 9, 2024 15:10
@MathiasVP MathiasVP added no-change-note-required This PR does not need a change note C++ labels Dec 9, 2024
@MathiasVP
Copy link
Contributor Author

MathiasVP commented Dec 9, 2024

Two new DCA results:

  • The cpp/path-injection one looks genuine
  • The cpp/potential-system-data-exposure is a FP because Samate doesn't consider usernames sensitive, but this query does.

@MathiasVP MathiasVP changed the title C++: Consider writes to array as uncertain C++: Consider writes to arrays as uncertain Dec 9, 2024
@MathiasVP MathiasVP merged commit 0f5786e into github:main Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants