WIP: SimpleRA BigInt Rewrite #18073
Closed
WIP: SimpleRA BigInt Rewrite #18073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d10c
force-pushed
the
d10c/simplera-bigint-rewrite
branch
from
6e98da5 to
78e8de4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1500,14 +1480,14 @@ | |||
| } | |||
|
|
|||
| /** Utility for `linearBoundFromGuard`. */ | |||
| private predicate getBounds(Expr expr, float boundValue, boolean isLowerBound) { | |||
| private predicate getBounds(Expr expr, QlBuiltins::BigInt boundValue, boolean isLowerBound) { | |||
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for merging, merely performance meansurements of BigInt.